feat: Custom-metadata, exists, info methods #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently waiting for an answer on supabase/storage#541 because I'm unsure about the correct types of the |
Vinzent03
changed the title
2 tasks
Pull Request Test Coverage Report for Build 14534435626Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Vinzent03
commented
Apr 18, 2025
| @@ -98,31 +108,15 @@ class Fetch { | |||
| filename: file.path, | |||
| contentType: contentType, | |||
| ); | |||
| final request = http.MultipartRequest(method, Uri.parse(url)) | |||
There was a problem hiding this comment.
The deleted code here is the same as in _handleBinaryFileRequest() so I added additional _handleFileRequest() instead to reduce code duplication. These two can now use an actual _handleMultipartRequest() method, which just accepts a MultipartFile which is independent of a passed File or Uint8List.
This reverts commit 502c611.
dshukertjr
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
No support for specifying metadata for files when uploading and missing info and exists methods.
What is the new behavior?
Support specifying metadata when uploading files.
Additional context
close #1021
js pr